Skip to content

Correct hydrateRoot return type#4735

Merged
rschristian merged 1 commit intopreactjs:mainfrom
plesiecki:patch-1
Mar 20, 2025
Merged

Correct hydrateRoot return type#4735
rschristian merged 1 commit intopreactjs:mainfrom
plesiecki:patch-1

Conversation

@plesiecki
Copy link
Contributor

Aligning type with implementation

preact/compat/client.js

Lines 18 to 21 in 29b0021

exports.hydrateRoot = function (container, children) {
hydrate(children, container);
return createRoot(container);
};

@github-actions
Copy link

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for CI

@coveralls
Copy link

Coverage Status

coverage: 99.61%. remained the same
when pulling 7998e45 on plesiecki:patch-1
into 29b0021 on preactjs:main.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rschristian rschristian merged commit 80ca668 into preactjs:main Mar 20, 2025
5 checks passed
@JoviDeCroock JoviDeCroock mentioned this pull request Mar 21, 2025
@plesiecki plesiecki changed the title correct hydrateRoot return type Correct hydrateRoot return type Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants